Removing date associated with shared service account section of BigQuery docs #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per discussion in today's BigQuery EOL Monthly check-in!
forstisabella
requested review from
markzegarelli
and removed request for
a team
markzegarelli
approved these changes
Mar 8, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
markzegarelli
pushed a commit
that referenced
this pull request
Mar 8, 2022
* StratConn GA Launch Docs Updates (#2566) * StratConn GA Launch Docs Updates * Update src/connections/destinations/catalog/actions-google-enhanced-conversions/index.md * Update src/connections/destinations/catalog/facebook-pixel-server-side/index.md * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Apply suggestions from code review Co-authored-by: rchinn-segment <[email protected]> * Add to tiktok doc * Update src/connections/destinations/catalog/tiktok-conversions/index.md Co-authored-by: Kiara Daswani <[email protected]> Co-authored-by: rchinn-segment <[email protected]> Co-authored-by: markzegarelli <[email protected]> * Removing date from docs (#2572) As per discussion in today's BigQuery EOL Monthly check-in! * Added clarity around what each icon means (#2574) Co-authored-by: Segment Docs Robot <[email protected]> Co-authored-by: kdaswani <[email protected]> Co-authored-by: Kiara Daswani <[email protected]> Co-authored-by: rchinn-segment <[email protected]> Co-authored-by: forstisabella <[email protected]>
markzegarelli
pushed a commit
that referenced
this pull request
Mar 8, 2022
* Update script ready * [netlify-build] * StratConn GA Launch Docs Updates (#2566) * StratConn GA Launch Docs Updates * Update src/connections/destinations/catalog/actions-google-enhanced-conversions/index.md * Update src/connections/destinations/catalog/facebook-pixel-server-side/index.md * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Update src/connections/destinations/catalog/tiktok-conversions/index.md * Apply suggestions from code review Co-authored-by: rchinn-segment <[email protected]> * Add to tiktok doc * Update src/connections/destinations/catalog/tiktok-conversions/index.md Co-authored-by: Kiara Daswani <[email protected]> Co-authored-by: rchinn-segment <[email protected]> Co-authored-by: markzegarelli <[email protected]> * Removing date from docs (#2572) As per discussion in today's BigQuery EOL Monthly check-in! * Added clarity around what each icon means (#2574) * updates Co-authored-by: stayseesong <[email protected]> Co-authored-by: Segment Docs Robot <[email protected]> Co-authored-by: kdaswani <[email protected]> Co-authored-by: Kiara Daswani <[email protected]> Co-authored-by: rchinn-segment <[email protected]> Co-authored-by: forstisabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As per discussion in today's BigQuery EOL Monthly check-in, removed the date from the shared service account note in the BigQuery documentation as this date didn't adequately reflect the cutoff for customers creating shared service accounts.
Merge timing
With the next regular docs release!
Related issues (optional)
#2506