Skip to content

Criteo forks/develop #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 3, 2022
Merged

Criteo forks/develop #2729

merged 20 commits into from
May 3, 2022

Conversation

stayseesong
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

#2721

@stayseesong stayseesong requested a review from a team as a code owner April 8, 2022 16:34
@stayseesong stayseesong requested review from forstisabella and removed request for a team April 8, 2022 16:34
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes, but otherwise should be good to go!

@stayseesong stayseesong added the new-integration Added a new source or destination label Apr 25, 2022
@stayseesong
Copy link
Contributor Author

@naevma there's 2 more outstanding questions that need your expertise to advise

@stayseesong stayseesong merged commit 1a23e10 into develop May 3, 2022
@stayseesong stayseesong deleted the criteo-forks/develop branch May 3, 2022 00:03
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants