Skip to content

Introducing the new Log Purchases Action #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

nielst
Copy link
Contributor

@nielst nielst commented Apr 8, 2022

Ship date of the feature still pending - would love review/edit of the steps in advance

Proposed changes

Merge timing

Sometime in May, TBD

Related issues (optional)

Ship date of the feature still pending - would love review/edit of the steps in advance
@nielst nielst requested a review from a team as a code owner April 8, 2022 18:22
@nielst nielst requested review from pwseg and removed request for a team April 8, 2022 18:22
@markzegarelli markzegarelli requested review from markzegarelli and removed request for pwseg April 8, 2022 18:24

To resolve this, purchase reporting takes place in a new Action called Log Purchase.

Any instances created after x/y has both Log Event and Log Purchase configured, but for prior instances you need to manually add the Log Purchases Action to report purchases to Amplitude:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nielst Is x/y here meant to represent a date?

@nielst nielst requested a review from stayseesong as a code owner May 3, 2022 21:12
@markzegarelli markzegarelli added content-update updates to content that are not new features, includes grammar fixes, added notes and removed new-feature labels Aug 29, 2022
@markzegarelli markzegarelli merged commit 1676e7c into develop Aug 29, 2022
@markzegarelli markzegarelli deleted the nielst-amplitude-log-purchases branch August 29, 2022 23:45
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request Aug 30, 2022
* More Pardot (Actions) updates for 8/30 deploy

* Fix minor typo

* Updated A.js Classic end of service note

* fix destination dossier for private destinations

* Add pagination and increase results (#3418)

* Add pagination and increase results

* add highlight

* Make moengage actions searchable in docs (#3417)

* Update Snapchat Conversions API docs prior to GA (#3416)

* Update Snapchat Conversions API docs prior to GA

* Update src/connections/destinations/catalog/actions-snap-conversions/index.md

Co-authored-by: stayseesong <[email protected]>

* Introducing the new Log Purchases Action (#2730)

* Introducing the new Log Purchases Action

Ship date of the feature still pending - would love review/edit of the steps in advance

* Edits

* Update heading

* Apply suggestions from code review

Co-authored-by: stayseesong <[email protected]>

* Update src/connections/destinations/catalog/actions-amplitude/index.md

Co-authored-by: markzegarelli <[email protected]>
Co-authored-by: stayseesong <[email protected]>

* repo sync (#3429)

* catalog update (#3430)

Co-authored-by: Segment Docs Robot <[email protected]>
Co-authored-by: kdaswani <[email protected]>
Co-authored-by: Phil Haack <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: Thomas Gilbert <[email protected]>
Co-authored-by: Niels <[email protected]>
markzegarelli pushed a commit that referenced this pull request Sep 1, 2022
* More Pardot (Actions) updates for 8/30 deploy

* Fix minor typo

* Updated A.js Classic end of service note

* fix destination dossier for private destinations

* Add pagination and increase results (#3418)

* Add pagination and increase results

* add highlight

* Make moengage actions searchable in docs (#3417)

* Update Snapchat Conversions API docs prior to GA (#3416)

* Update Snapchat Conversions API docs prior to GA

* Update src/connections/destinations/catalog/actions-snap-conversions/index.md

Co-authored-by: stayseesong <[email protected]>

* Introducing the new Log Purchases Action (#2730)

* Introducing the new Log Purchases Action

Ship date of the feature still pending - would love review/edit of the steps in advance

* Edits

* Update heading

* Apply suggestions from code review

Co-authored-by: stayseesong <[email protected]>

* Update src/connections/destinations/catalog/actions-amplitude/index.md

Co-authored-by: markzegarelli <[email protected]>
Co-authored-by: stayseesong <[email protected]>

* repo sync (#3429)

* catalog update (#3430)

* Update how zlib must be referenced in functions docs (#3438)

* Add note to GEC about order ID requirements (#3440)

Co-authored-by: Segment Docs Robot <[email protected]>
Co-authored-by: kdaswani <[email protected]>
Co-authored-by: Phil Haack <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: Thomas Gilbert <[email protected]>
Co-authored-by: Niels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants