Bundle Obfuscation [DOC-508] #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielsilvestri
requested review from
stayseesong and
pooyaj
and removed request for
a team
stayseesong
changed the title
stayseesong
reviewed
Apr 28, 2022
| @@ -493,6 +493,16 @@ An example: | |||
| analytics.load('writekey', { integrations: { All: false, 'Google Analytics': true, 'Segment.io': true } }) | |||
| ``` | |||
|
|
|||
| You can also add an `obfuscate` property to the object taken as a second argument, which will obscure the url from which your integrations and actions are loaded. This is helpful for names that are commonly flagged by ad blockers. | |||
There was a problem hiding this comment.
@arielsilvestri some clarifying questions:
- When you say actions, do you mean destination actions?
- When you say "This is helpful for names that are commonly flagged by ad blockers," just want to clarify, why is obfuscation helpful for names that are flagged by ad blockers? Do you mean to say, "This helps names that are commonly flagged by ad blockers to not be detected."?
There was a problem hiding this comment.
- Correct, I will update that to say "integrations and destination actions".
- Sure, some clarification there - the goal of [this project was to provide ways for our customers to help mitigate how often commonly blocked words in urls would prevent certain integrations from properly loading. With this change, something like
adobe-analyticswould no longer appear in any part of the URL, as a small example.
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
hi @arielsilvestri was your most recent commit intentional? Looks like the rebase you committed didn't resolve conflicts properly |
|
ack, weird. Let me see if I can fix that. |
stayseesong
approved these changes
May 3, 2022
stayseesong
changed the title
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Announcing our obfuscation feature to customers.
Merge timing
Need to clarify if we have any other comms to make before merging this, but I will ping here once I have that confirmed.