Skip to content

small update to gtag docs #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

small update to gtag docs #2820

merged 1 commit into from
Apr 28, 2022

Conversation

kdaswani
Copy link
Contributor

Proposed changes

Fix contradictory info about what to use in the integrations object.

Merge timing

  • ASAP once approved

Related issues (optional)

https://segment.slack.com/archives/CQ1F92KUG/p1651158370312849

@markzegarelli markzegarelli added the content-update updates to content that are not new features, includes grammar fixes, added notes label Apr 28, 2022
@markzegarelli markzegarelli merged commit a7806f5 into develop Apr 28, 2022
@markzegarelli markzegarelli deleted the gtag-update branch April 28, 2022 21:50
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

markzegarelli pushed a commit that referenced this pull request May 3, 2022
* Added Criteo Audiences documentation

* updated Criteo description

* edits

* new edits to text

* edits to text

* edits to text

* edits

* reformatted

* updated description

* updated description

* added include statement to pull available actions, fields, settings

* Formatted warning

* added a note about delay

* update word accept list

* criteo doc edits

* Apply suggestions from code review

Co-authored-by: forstisabella <[email protected]>

* Draft of GA4 changes

* Update src/connections/destinations/catalog/actions-criteo-audiences/index.md

Co-authored-by: forstisabella <[email protected]>

* Documentation for the obfuscate feature and how to use it

* updates to ga4 draft

* Apply suggestions from code review

* note on nesting

* small update to gtag docs (#2820)

* [netlify-build]

* [netlify-build]

* Apply suggestions from code review

* Clarify which actions are obfuscated

* Update src/connections/destinations/catalog/actions-google-analytics-4/index.md

* Update src/connections/destinations/catalog/actions-google-analytics-4/index.md

* Update src/connections/destinations/catalog/actions-google-analytics-4/index.md

* Update src/connections/destinations/catalog/actions-google-analytics-4/index.md

* Update src/connections/destinations/catalog/actions-google-analytics-4/index.md

* Apply suggestions from code review

Co-authored-by: rchinn-segment <[email protected]>

* Remove inactive destinations (#2827)

* remove inactive destinations

* ran make catalog

Co-authored-by: markzegarelli <[email protected]>

* Apply suggestions from code review

Co-authored-by: stayseesong <[email protected]>

* Apply suggestions from code review

Co-authored-by: forstisabella <[email protected]>

* Update index.md

* Update proxy process

* Proper merge of upstream

* edits

* Fixed some broken URLs (#2829)

* Revert "Bundle Obfuscation [DOC-508]"

* Update index.md

Co-authored-by: Nadine Malek <[email protected]>
Co-authored-by: Sai Harika Punyamurthula <[email protected]>
Co-authored-by: Sai Harika Punyamurthula <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: stayseesong <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: kdaswani <[email protected]>
Co-authored-by: Ariel Silvestri <[email protected]>
Co-authored-by: Segment Docs Robot <[email protected]>
Co-authored-by: rchinn-segment <[email protected]>
Co-authored-by: jinapark202 <[email protected]>
Co-authored-by: Niall Brennan <[email protected]>
Co-authored-by: pwseg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants