Updating the Postgres RDS docs [DOC-504] #2822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forstisabella
added
the
content-update
markzegarelli
suggested changes
Apr 29, 2022
There was a problem hiding this comment.
Looks good!
A few general comments:
- Please add
{:target="_blank"}to all external URLs. - I'm not sure the troubleshooting section at the bottom needs to be a table. Changing these to headings / paragraphs will help searchability and maintainability. I also noticed one instance of
wein one of the cells.
|
|
||
| As a supplement to this guide, Amazon has created an official guide to [setting up a Postgres database](http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_GettingStarted.CreatingConnecting.PostgreSQL.html). | ||
| Create a new PostgreSQL database in RDS by following the steps in Amazon's documentation, [Creating a PostgreSQL DB instance and connecting to a database on a PostgreSQL DB instance](http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_GettingStarted.CreatingConnecting.PostgreSQL.html). For best performance, create your database in the `US West` region. |
There was a problem hiding this comment.
You can reorder the first sentence to make it active-voice.
"Follow the steps in Amazon's documentation to create a new PostgreSQL..."
markzegarelli
approved these changes
Apr 29, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
This was referenced May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I’ve updated the Network Permissions section so that it references correct UI terms, and removed the step-by-step instructions for creating an PostgreSQL database to instead link to AWS’s DB creation docs (so we’re not on the hook for updating the instructions again when AWS makes more UI changes.)
Merge timing
With the next regular docs release, pending approval from the PM for this product!
Related issues (optional)
#2735