Add 'in' operator to FQL documentation #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysonmote
requested review from
rchinn1 and
jayakrishnannair
and removed request for
a team
| @@ -100,6 +105,7 @@ If your field name has a character not in the set of `{a-z A-Z 0-9 _ -}`, you mu | |||
| | `>=` | `number` | `number` | `true` if the left side is greater than or equal to the right side. | | |||
| | `<` | `number` | `number` | `true` if the left side is less than the right side. | | |||
| | `<=` | `number` | `number` | `true` if the left side is less than or equal to the right side. | | |||
| | `in` | `string`, `number`, `bool`, or `null` | `list` | `true` if the left side is contained in the list of values. | | |||
There was a problem hiding this comment.
Looks good. Wondering if we should mention that using in is much more efficient than chaining or conditions.
There was a problem hiding this comment.
I don't think so, personally. Customers shouldn't have to worry about our internal implementation's efficiency, and it wouldn't make a difference to them anyways.
jayakrishnannair
approved these changes
May 6, 2022
rchinn1
approved these changes
May 6, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the new 'in' operator to the FQL documentation.
Merge timing
As soon as it is approved.