Skip to content

Engage Setting User Subscription Updates #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 10, 2022
Merged

Engage Setting User Subscription Updates #2857

merged 8 commits into from
May 10, 2022

Conversation

pwseg
Copy link
Contributor

@pwseg pwseg commented May 8, 2022

Proposed changes

  • Added rewritten content on setting user subscriptions.

Merge timing

  • ASAP once approved.

@pwseg pwseg added the content When the bug is about content that needs to get fixed label May 8, 2022
rchinn1
rchinn1 reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! QQ: Do you think we need a note about resubscribe limitations in beta? I’ve inquired into updates on this, but last I heard resubscribing through CSV is currently not possible.

@pwseg
Copy link
Contributor Author

pwseg commented May 9, 2022

Looks great! QQ: Do you think we need a note about resubscribe limitations in beta? I’ve inquired into updates on this, but last I heard resubscribing through CSV is currently not possible.

Yeah, great point. I've commented that section out for now so that we can have it ready to go once it's available.

@pwseg pwseg closed this May 9, 2022
@pwseg pwseg reopened this May 9, 2022
@pwseg pwseg requested a review from rchinn1 May 9, 2022 22:51
@pwseg pwseg merged commit 23ad842 into master May 10, 2022
@pwseg pwseg deleted the set-user-subscriptions branch May 10, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchinn1 rchinn1 rchinn1 approved these changes

@markzegarelli markzegarelli Awaiting requested review from markzegarelli

Assignees
No one assigned
Labels
content When the bug is about content that needs to get fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwseg @rchinn1