Variance alias support #2942
Merged
Variance alias support #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmathieu, just checking, did you mean to submit this as a draft or is it ready for review? |
|
Hi @stayseesong, I'm waiting on Segment's engineering team to update our integration. Once updated, I'll submit this PR for review. Here's the ticket if you have access. Thanks for following up |
|
@stayseesong @gmathieu the code update is now in place! feel free to go ahead and review/merge this request. |
stayseesong
previously requested changes
Jun 29, 2022
|
@stayseesong I addressed your feedback. Thanks! |
markzegarelli
approved these changes
Jul 5, 2022
markzegarelli
added
the
content-update
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add Alias method docs now that Variance supports it.
Merge timing
ASAP 🙏
Related issues (optional)