Skip to content

fixes for sources and destinations overview #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

stayseesong
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@stayseesong stayseesong requested review from markzegarelli and a team as code owners August 11, 2022 16:29
@stayseesong stayseesong marked this pull request as draft August 11, 2022 16:29
@stayseesong stayseesong marked this pull request as ready for review August 26, 2022 19:46
@stayseesong
Copy link
Contributor Author

@markzegarelli this one is ready for review with my first pass

Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

The only thing I'd like to change is the video (called out in a separate comment). It lacks polish and context. If we can replace that with images + text, I think it would be better.

> note ""
> Destination Filters are available to Business Tier customers only.
> info ""
> Destination Filters are only available to Business Tier customers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the word only here. "Destination Filters are available to Business Tier customers." gets the point across.


Some destinations offer settings that also allow you to filter data. For example, the Facebook App Events destination allows you to map `Screen` events to `Track` events. Because Destination Filters are evaluated and applied _before_ the Destination settings are applied, they can conflict with your settings.

In the example in the video above, if you have a Destination Filter that filters Track events _and_ you have the **Use Screen Events as Track Events** setting enabled, `Track` events will be dropped, but `Screen` events still process. The destination settings will transform it into a `Track` event - *after* the filters.
In the example in [the video](https://www.youtube.com/watch?v=47dhAF1Hoco){:target="_blank"}, if you have a Destination Filter that filters Track events _and_ you have the **Use Screen Events as Track Events** setting enabled, `Track` events drop, but `Screen` events still process. The destination settings transform it into a `Track` event - *after* the filters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like a video here. Could this be done with text or still images?

@stayseesong stayseesong force-pushed the destinations-sources-overview-fixes branch from d3215f5 to 72e41ca Compare September 8, 2022 16:06
@stayseesong stayseesong merged commit 966f907 into develop Sep 8, 2022
@stayseesong stayseesong deleted the destinations-sources-overview-fixes branch September 8, 2022 16:18
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@stayseesong stayseesong added the content-update updates to content that are not new features, includes grammar fixes, added notes label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants