Update Castle destination docs #3610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayseesong
requested changes
Oct 5, 2022
stayseesong
added
the
content-update
markzegarelli
suggested changes
Oct 5, 2022
There was a problem hiding this comment.
Thanks @wallin!
I've requested some changes to help this doc fit in with the rest of our docset.
Co-authored-by: stayseesong <[email protected]> Co-authored-by: markzegarelli <[email protected]>
wallin
commented
Oct 6, 2022
wallin
commented
Oct 6, 2022
Co-authored-by: markzegarelli <[email protected]>
|
Thank you for great feedback @markzegarelli @stayseesong! I've now updated the PR and hopefully addressed all your comments |
wallin
requested review from
markzegarelli and
stayseesong
and removed request for
markzegarelli
markzegarelli
approved these changes
Oct 6, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
|
@markzegarelli @stayseesong Thanks for merging this. How do I update the available options in the settings section here: https://segment.com/docs/connections/destinations/catalog/castle/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating docs to match the latest technical changes
segmentio/analytics.js-integrations#671
Merge timing
ASAP once approved
Related issues (optional)