Skip to content

Add section for api token security [SECFEAT-1021] #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2023

Conversation

salolivares
Copy link
Contributor

@salolivares salolivares commented Dec 8, 2022

Proposed changes

This PR adds a section under the public api page in order to describe a new feature that is being rolled out (exposed papi token service, see sdd here).

Screen Shot 2022-12-07 at 6 39 24 PM

Merge timing

This depends on https://github.com/segmentio/exposed-papi-token-service being shipped to production. We're aiming for an early January release.

@salolivares salolivares marked this pull request as ready for review December 8, 2022 18:12
@salolivares salolivares requested a review from a team as a code owner December 8, 2022 18:12
@salolivares salolivares requested review from stayseesong and removed request for a team December 8, 2022 18:12
@markzegarelli markzegarelli changed the title add section for api token security [SECFEAT-1021] Add section for api token security [SECFEAT-1021] Dec 8, 2022
@salolivares salolivares self-assigned this Dec 9, 2022
@stayseesong
Copy link
Contributor

@salolivares when you get an exact date for when this is being shipped to production, can you let me know? Want to make sure this goes out on the right date. Thanks!

@salolivares
Copy link
Contributor Author

@stayseesong will do! We're aiming for a early January release. I'll ping once we figure out a hard date.

@salolivares salolivares force-pushed the add-github-token-scanning branch from a469d56 to 26649c7 Compare January 13, 2023 22:34
@salolivares salolivares force-pushed the add-github-token-scanning branch from 26649c7 to a61448e Compare January 13, 2023 22:37
@salolivares
Copy link
Contributor Author

salolivares commented Jan 13, 2023

@stayseesong the feature is going live! when can we have the docs published?

@stayseesong
Copy link
Contributor

@salolivares when is it going live?

@salolivares
Copy link
Contributor Author

@stayseesong this feature is live now! (1/17)

@stayseesong
Copy link
Contributor

@salolivares ok! will get the docs to deploy today

@stayseesong stayseesong merged commit e970dc2 into develop Jan 17, 2023
@stayseesong stayseesong deleted the add-github-token-scanning branch January 17, 2023 17:24
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants