Skip to content

Replace public-segment-devcenter-production S3 URLs with CloudFront URLs [DC-265] #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

konoufo
Copy link
Contributor

@konoufo konoufo commented Jan 10, 2023

This PR replaces the hardcoded S3 URLs pointing to bucket public-segment-devcenter-production with corresponding CloudFront URLs.

Created by Sourcegraph batch change mohamed.coulibali/replace-s3-with-cloudfront.

@konoufo konoufo requested a review from a team as a code owner January 10, 2023 16:46
@konoufo konoufo requested review from forstisabella and removed request for a team January 10, 2023 16:46
@markzegarelli
Copy link
Contributor

@konoufo These files are generated automatically with output from the Public API. Are these URLs updated on the backend / in Partner Portal?

@konoufo
Copy link
Contributor Author

konoufo commented Jan 10, 2023

@konoufo These files are generated automatically with output from the Public API. Are these URLs updated on the backend / in Partner Portal?

@markzegarelli Hum, interesting! Thank you for pointing this out. We are planning to replace all control-plane-db entries containing S3 URLs related to this bucket next week. Which should probably do it. But for awareness, would you guide me to where exactly these are generated ?

@markzegarelli
Copy link
Contributor

@konoufo Cool! Updating them directly in control-plane should do it, as I believe that is what feeds the Public API. I'm not sure where these are generated though. I know the Dev Portal supports uploading image files for logos, but I do not know how that ties into the back end.

Docs are very much end-of-chain in this process.

@konoufo
Copy link
Contributor Author

konoufo commented Jan 10, 2023

@markzegarelli ok I see there is a script here that generates these files. Is the script run manually or at deploy-time on Netlify ?
In either case then can you accept this PR so that I will just make sure to remember to merge these changes here when we are done with the migration on control-plane-db. Worst case scenario it will trigger the necessary re-deploy.
I want to make sure we don't forget any broken links when we end up blocking direct S3 URLs.

@markzegarelli
Copy link
Contributor

@konoufo We run the script manually before we deploy, so that updates are committed to the repository.

My preference for this PR is to close it, since once the updates are done in control-plane, we will get the updates that way. We've had issues in the past when we manually update this file.

@konoufo
Copy link
Contributor Author

konoufo commented Jan 21, 2023

@konoufo We run the script manually before we deploy, so that updates are committed to the repository.

My preference for this PR is to close it, since once the updates are done in control-plane, we will get the updates that way. We've had issues in the past when we manually update this file.

Closing this as per @markzegarelli recommendation.

@konoufo konoufo closed this Jan 21, 2023
@konoufo konoufo reopened this Jan 23, 2023
@konoufo konoufo force-pushed the batch-changes/replace-s3-with-cloudfront branch from 80f82d2 to 93b72c1 Compare January 23, 2023 17:48
@konoufo
Copy link
Contributor Author

konoufo commented Jan 23, 2023

@markzegarelli The autogenerated have been updated as you said they would, thank you. I'm reopening after noticing that at least examples/sources.example.yml was not autogenerated. I'm dropping changes on all other files but this one.

@markzegarelli markzegarelli added the back-end fixes or updates to the site itself, which should not go in release notes label Jan 24, 2023
@markzegarelli markzegarelli merged commit 1630cb2 into develop Jan 24, 2023
@markzegarelli markzegarelli deleted the batch-changes/replace-s3-with-cloudfront branch January 24, 2023 17:46
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end fixes or updates to the site itself, which should not go in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants