-
Notifications
You must be signed in to change notification settings - Fork 367
Replace public-segment-devcenter-production S3 URLs with CloudFront URLs [DC-265] #4020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace public-segment-devcenter-production S3 URLs with CloudFront URLs [DC-265] #4020
Conversation
@konoufo These files are generated automatically with output from the Public API. Are these URLs updated on the backend / in Partner Portal? |
@markzegarelli Hum, interesting! Thank you for pointing this out. We are planning to replace all control-plane-db entries containing S3 URLs related to this bucket next week. Which should probably do it. But for awareness, would you guide me to where exactly these are generated ? |
@konoufo Cool! Updating them directly in control-plane should do it, as I believe that is what feeds the Public API. I'm not sure where these are generated though. I know the Dev Portal supports uploading image files for logos, but I do not know how that ties into the back end. Docs are very much end-of-chain in this process. |
@markzegarelli ok I see there is a script here that generates these files. Is the script run manually or at deploy-time on Netlify ? |
@konoufo We run the script manually before we deploy, so that updates are committed to the repository. My preference for this PR is to close it, since once the updates are done in control-plane, we will get the updates that way. We've had issues in the past when we manually update this file. |
Closing this as per @markzegarelli recommendation. |
80f82d2
to
93b72c1
Compare
@markzegarelli The autogenerated have been updated as you said they would, thank you. I'm reopening after noticing that at least |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
This PR replaces the hardcoded S3 URLs pointing to bucket
public-segment-devcenter-production
with corresponding CloudFront URLs.Created by Sourcegraph batch change
mohamed.coulibali/replace-s3-with-cloudfront
.