Skip to content

Add clarity to source URL vs Source ID #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

sarahrudy
Copy link
Contributor

Proposed changes

Added clarity around the Source URL and Source ID we ask customers to provide when setting up their custom proxy.

Merge timing

  • ASAP once approved?

Related issues (optional)

N/A

@sarahrudy sarahrudy added the KCS label Jan 10, 2023
@markzegarelli markzegarelli changed the title Update custom-proxy.md Add clarity to source URL vs Source ID Jan 11, 2023
@sarahrudy sarahrudy marked this pull request as ready for review January 18, 2023 22:39
@sarahrudy sarahrudy requested a review from a team as a code owner January 18, 2023 22:39
@sarahrudy sarahrudy requested review from rchinn1 and removed request for a team January 18, 2023 22:39
@rchinn1 rchinn1 added content-update updates to content that are not new features, includes grammar fixes, added notes and removed content-update updates to content that are not new features, includes grammar fixes, added notes labels Jan 18, 2023
@rchinn1 rchinn1 merged commit 128b6b6 into sarahrudy-patch-1 Jan 18, 2023
@rchinn1 rchinn1 deleted the sarahrudy-patch-2 branch January 18, 2023 23:06
@rchinn1
Copy link
Contributor

rchinn1 commented Jan 18, 2023

Hi @sarahrudy, looks like this was merged from sarahrudy-patch-2 into sarahrudy-patch-1. Did you want these updates merged into develop?

@sarahrudy
Copy link
Contributor Author

Hi @rchinn-segment, yes, please

@rchinn1
Copy link
Contributor

rchinn1 commented Jan 30, 2023

@sarahrudy I'll have these updates included in our next deploy. #4149

rchinn1 added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants