Skip to content

update api links #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2023
Merged

update api links #4097

merged 3 commits into from
Jan 23, 2023

Conversation

tcgilbert
Copy link
Contributor

Proposed changes

Looks like there was a site wide change to update any mention of the "Config API" with the "Public API" back in september. Unfortunately, the tokens generated from the "enable with oauth" flow are only compatible with the config api, so this has caused some confusion for partners with 1.0 integrations.

Merge timing

asap

@tcgilbert tcgilbert requested a review from a team as a code owner January 20, 2023 18:52
@tcgilbert tcgilbert requested review from rchinn1 and removed request for a team January 20, 2023 18:52
@rchinn1 rchinn1 added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jan 21, 2023
@@ -2,25 +2,25 @@
title: Enable with OAuth
---

Enable with OAuth, supported with the [Public API](/docs/api/public-api), allows partners to build seamless flows for customers to implement and enable integrations within their workspace. This is a [post-launch requirement](/docs/partners/#post-launch) for a partner to graduate from public beta to public.
Enable with OAuth, supported with the [Config API](/docs/api/config-api), allows partners to build seamless flows for customers to implement and enable integrations within their workspace. This is a [post-launch requirement](/docs/partners/#post-launch) for a partner to graduate from public beta to public.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tcgilbert, just want to confirm that graduating from public beta to public is correct, as opposed to something like private beta to public.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"public beta to public" is the standard we set for dev center 1.0 destinations. It is slightly different with 2.0 integrations, in that there is no enable with oauth requirement.

Being that 1.0 is legacy I'd be okay with removing the last sentence entirely:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. I removed the last sentence and will include these updates in our next deploy.

@rchinn1 rchinn1 merged commit 7aac233 into develop Jan 23, 2023
@rchinn1 rchinn1 deleted the thomas/oauth branch January 23, 2023 17:24
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants