Skip to content

Fix link to Reset section #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix link to Reset section #4116

merged 1 commit into from
Jan 24, 2023

Conversation

hugihlynsson
Copy link
Contributor

Proposed changes

The link to the Reset (Logout) section didn't do anything. The issue was that it was linking to #reset-or-logout while the anchor was #reset-or-log-out. This PR fixes the link by using the correct anchor. I could have changed the anchor but that would have caused existing links to it to break and just end up at the top of the page.

Merge timing

  • ASAP once approved

@hugihlynsson hugihlynsson requested a review from a team as a code owner January 24, 2023 16:51
@hugihlynsson hugihlynsson requested review from pwseg and removed request for a team January 24, 2023 16:51
@pwseg pwseg added the fixed-content fix to content that has outdated or wrong information label Jan 24, 2023
@pwseg pwseg merged commit 86af02c into segmentio:develop Jan 24, 2023
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants