update to reflect source ID > secret ID change #4182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segment used to connect to Amazon Kinesis Firehose via `sourceId`. Recently, an update was made for security reasons to use a Secret ID that is automatically created in the Settings for each Amazon Kinesis Firehose destination in Segment instead. Our documentation doesn't reflect this which leads to confusion for customers. This change updates our documentation to reflect the new way Segment connects to Firehose through Secret ID.
spencerattick
requested review from
stayseesong and
markzegarelli
as code owners
markzegarelli
approved these changes
Feb 3, 2023
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Segment used to connect to Amazon Kinesis Firehose via
sourceId. Recently, an update was made for security reasons to use a Secret ID that is automatically created in the Settings for each Amazon Kinesis Firehose destination in Segment instead. Our documentation doesn't reflect this which leads to confusion for customers. This change updates our documentation to reflect the new way Segment connects to Firehose through Secret ID.Merge timing
ASAP is fine