Added information that sending of null property or trait is not possible. #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information that sending of null property or trait is not possible. In the following section: > **Good to know**: For any of the different methods described on this page, you can replace the properties and traits in the code samples with variables that represent the data collected. Added: "Note that sending of null property or trait will not be possible as Guava’s immutable maps will reject the null value and GSON library use to serilaize the Java object will ignore the null value. As a workaround, send an empty string instead of a null value in the property or trait."
tanjinhong72
changed the title
As indicated in https://segment.atlassian.net/browse/KCS-145, making the following changes 1.) Just a slight rewording/typo fixing: "Note that sending a property or trait with a null value will not be possible as Guava's immutable maps will reject the null value and the GSON library used to serialize the Java object will ignore it. As a workaround, you can send an empty string instead of a null value in on your properties or traits." 2.) The Identify heading is above the Good to know section when it probably shouldn’t be. Move the Identify heading below the Good to know box when update PR.
|
hi @tanjinhong72, is there a reason why you moved this note around and added it to the Regional Configuration section? |
|
Hi @stayseesong , sorry on the late reply. The 'Good to know' note is meant for identify and track types, so initially it feels better to have it above the Identify section. However, I do see the point that it looks even more unappropriate to be under Regional Configuration section. So it's fine to put the 'Good to know' note back under Identify section. |
stayseesong
approved these changes
Mar 21, 2023
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the past, there were some tickets on customer asking about sending null property and trait. Engineering has also confirmed that this is not possible.
Added information that sending of null property or trait is not possible.
In the following section:
Added:
"Note that sending of null property or trait will not be possible as Guava’s immutable maps will reject the null value and GSON library use to serilaize the Java object will ignore the null value. As a workaround, send an empty string instead of a null value in the property or trait."
Merge timing
Related issues (optional)
(https://segment.zendesk.com/agent/tickets/498628)