Skip to content

Sentry destination update #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Sentry destination update #4415

merged 5 commits into from
Apr 11, 2023

Conversation

vanand17
Copy link
Contributor

Proposed changes

We have had multiple cases of customers questioning how Sentry destination works when added as a destination since it doesn't report errors out of the box. Since it is an error tracking tool, I feel we could have the following section in our docs for clarification.

Merge timing

NA

Related issues (optional)

NA

@vanand17 vanand17 added the KCS label Mar 14, 2023
@vanand17 vanand17 marked this pull request as ready for review March 21, 2023 01:24

Since Sentry is an error tracking application, we need to make sure to send something broken from the website to see the event appear in Sentry dashboard. For example, firing the following error event from the web console, Sentry.captureException(new Error("Some error"));we can see the relevant event payload with the event_id information as below -

![image](https://user-images.githubusercontent.com/96406241/226262825-d038a0c6-acbc-4b20-87bb-558c622a2be5.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanand17 is it necessary to include this image? The image quality is also very poor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stayseesong I think the image is ok to include here, since it's not specific to any UI, but rather shows where to find an event_id in the chrome inspector.

@vanand17 Can you supply a full resolution image that is not marked up?


![image](https://user-images.githubusercontent.com/96406241/226262825-d038a0c6-acbc-4b20-87bb-558c622a2be5.png)

This error will appear in Sentry with the same event_id we saw on the web console. This helps verify that we have the correct implementation of the destination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This error will appear in Sentry with the same event_id we saw on the web console. This helps verify that we have the correct implementation of the destination.
The error appears in Sentry with the same `event_id` seen on the web console. This helps to verify that Segment has the correct implementation of the destination.

@markzegarelli
Copy link
Contributor

@vanand17 can you send a full screen, not marked up version of the screenshot you've added to me Slack? I think GitHub may have compressed or shrunk it.

stayseesong

This comment was marked as resolved.

@vanand17
Copy link
Contributor Author

Hi @markzegarelli and @stayseesong I did not want to add the entire page as it has my test website name on it, and we thought it would be better to avoid having it in Public documentation.

Is there any other way I can provide you with the screenshot?

@stayseesong
Copy link
Contributor

@vanand17 can you try taking the screenshot on your computer screen rather than from your external monitor? The resolution comes out better this way

@markzegarelli
Copy link
Contributor

@vanand17 We will crop the screenshot to a final size, we just want the original size to start with.

@vanand17
Copy link
Contributor Author

Thanks. Here is the screenshot from my laptop screens and not my external monitor.
image

Please let me know if I need to update it in the PR itself

@markzegarelli markzegarelli merged commit 59d5395 into develop Apr 11, 2023
@markzegarelli markzegarelli deleted the vanand17-patch-10 branch April 11, 2023 16:33
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants