Skip to content

Add 'disable' setting to node docs #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Apr 3, 2023

Proposed changes

Setting update

@silesky silesky requested a review from a team as a code owner April 3, 2023 20:05
@silesky silesky requested review from pwseg and removed request for a team April 3, 2023 20:05
@silesky silesky changed the title add disable setting to node docs Add 'disable' setting to node docs Apr 3, 2023
@@ -60,9 +60,12 @@ If you're using the [classic version of Analytics Node.js](/docs/connections/sou
```
* The `flushAt` configuration option changed to `maxEventsInBatch`.

* The `flushAt` configuration option changed to `maxEventsInBatch`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silesky this line already exists in line 61

@silesky silesky requested a review from stayseesong April 4, 2023 22:58
@silesky silesky requested a review from stayseesong April 5, 2023 18:27
@stayseesong stayseesong merged commit d34e0ee into develop Apr 6, 2023
@stayseesong stayseesong deleted the uodate-node-with-disabled branch April 6, 2023 15:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants