SQL trait name clarification #4941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Identifier Added the following question and answer to indicate that the name of SQL trait should not be the same name as the identifier. ### Why doesn't the identifier updated by SQL trait shows the correct value found in the column? Ensure that the name given to the SQL trait is not the same name as the identifier or column name from the query. To use SQL trait to update the identifier, the identifier will need to be a column in the query of your SQL trait. The column name in the query of SQL trait should be the one that Identity Resolution use to generate the identifier.
rchinn1
approved these changes
Jul 31, 2023
rchinn1
changed the title
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added the following question and answer to indicate that the name of SQL trait should not be the same name as the identifier.
"Why doesn't the identifier updated by SQL trait shows the correct value found in the column?
Ensure that the name given to the SQL trait is not the same name as the identifier or column name from the query. To use SQL trait to update the identifier, the identifier will need to be a column in the query of your SQL trait. The column name in the query of SQL trait should be the one that Identity Resolution use to generate the identifier."
Issue occurred in ticket https://segment.zendesk.com/agent/tickets/509275. Customer use an SQL trait with a name that is the same as the identifier, and resulted in Identifier with incorrect value.
Merge timing
Related issues (optional)
https://segment.zendesk.com/agent/tickets/509275