Skip to content

Update doc: iOS does not support destination middleware #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

joeynmq
Copy link
Contributor

@joeynmq joeynmq commented Jul 27, 2023

Proposed changes

There is a known issue where destination middlewares are not functioning well for the iOS library. The Engineering team will now be focusing on the new libraries (Swift & Kotlin) so the issue won't be fixed.

JIRA: https://segment.atlassian.net/browse/LIBMOBILE-635

Merge timing

ASAP once approved

@niallzato niallzato added the KCS label Jul 27, 2023
Copy link
Contributor

@niallzato niallzato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some small changes requested.

@joeynmq joeynmq marked this pull request as ready for review August 21, 2023 04:32
@joeynmq joeynmq requested a review from a team as a code owner August 21, 2023 04:32
@joeynmq joeynmq requested review from forstisabella and removed request for a team August 21, 2023 04:32
@forstisabella
Copy link
Contributor

@joeynmq does Niall need to re-review this or can I go ahead and merge?

@joeynmq
Copy link
Contributor Author

joeynmq commented Aug 28, 2023

hey @forstisabella the KCS ticket has been approved, thank you!!

@forstisabella forstisabella merged commit 0ba9642 into develop Aug 28, 2023
@forstisabella forstisabella deleted the joeynmq-patch-4 branch August 28, 2023 16:32
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants