-
Notifications
You must be signed in to change notification settings - Fork 367
Update doc: iOS does not support destination middleware #5078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some small changes requested.
src/connections/sources/catalog/libraries/mobile/ios/middleware.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/mobile/ios/middleware.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/mobile/ios/middleware.md
Outdated
Show resolved
Hide resolved
src/connections/sources/catalog/libraries/mobile/ios/middleware.md
Outdated
Show resolved
Hide resolved
…e.md Co-authored-by: Niall Brennan <[email protected]>
…e.md Co-authored-by: Niall Brennan <[email protected]>
…e.md Co-authored-by: Niall Brennan <[email protected]>
…e.md Co-authored-by: Niall Brennan <[email protected]>
@joeynmq does Niall need to re-review this or can I go ahead and merge? |
hey @forstisabella the KCS ticket has been approved, thank you!! |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
There is a known issue where destination middlewares are not functioning well for the iOS library. The Engineering team will now be focusing on the new libraries (Swift & Kotlin) so the issue won't be fixed.
JIRA: https://segment.atlassian.net/browse/LIBMOBILE-635
Merge timing
ASAP once approved