update the BQ permission requirement section #5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneewang21
requested review from
forstisabella and
stayseesong
and removed request for
a team
stayseesong
requested changes
Jul 31, 2023
| @@ -39,4 +39,11 @@ Permission | Details | |||
| `bigquery.datasets.get` | This allows Segment to determine if the aforementioned dataset exists | |||
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets/tables your model query references and manage tables that Segment uses for tracking | |||
|
|
|||
| The `bigquery.datasets.*` permissions can be scoped only to the `__segment_reverse_etl` dataset. If you don't wish to grant `bigquery.datasets.create` access, you may create this dataset yourself, but Segment still needs `bigquery.datasets.get` access. | |||
| If you don't wish to grant `bigquery.datasets.create` access, you may create this dataset yourself, and Segment needs the following permissions: | |||
There was a problem hiding this comment.
Suggested change
| If you don't wish to grant `bigquery.datasets.create` access, you may create this dataset yourself, and Segment needs the following permissions: | |
| If you don't want to grant Segment `bigquery.datasets.create` access, you can create your own `__segment_reverse_etl` dataset and give Segment the following permissions: |
| @@ -39,4 +39,11 @@ Permission | Details | |||
| `bigquery.datasets.get` | This allows Segment to determine if the aforementioned dataset exists | |||
There was a problem hiding this comment.
Suggested change
| `bigquery.datasets.get` | This allows Segment to determine if the aforementioned dataset exists | |
| `bigquery.datasets.get` | This allows Segment to determine if the aforementioned dataset exists. |
| @@ -39,4 +39,11 @@ Permission | Details | |||
| `bigquery.datasets.get` | This allows Segment to determine if the aforementioned dataset exists | |||
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets/tables your model query references and manage tables that Segment uses for tracking | |||
There was a problem hiding this comment.
Suggested change
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets/tables your model query references and manage tables that Segment uses for tracking | |
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets/tables your model query references and manage tables that Segment uses for tracking. |
Comment on lines
45
to
47
| `bigquery.datasets.get` | This allows Segment to determine if the `__segment_reverse_etl` dataset exists | ||
| `bigquery.tables.create` | This allows Segment to determine if the tables Segment uses to track state in `__segment_reverse_etl` dataset exists | ||
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets/tables your model query references and manage tables that Segment uses for tracking |
There was a problem hiding this comment.
Suggested change
| `bigquery.datasets.get` | This allows Segment to determine if the `__segment_reverse_etl` dataset exists | |
| `bigquery.tables.create` | This allows Segment to determine if the tables Segment uses to track state in `__segment_reverse_etl` dataset exists | |
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets/tables your model query references and manage tables that Segment uses for tracking | |
| `bigquery.datasets.get` | This allows Segment to determine if the `__segment_reverse_etl` dataset exists. | |
| `bigquery.tables.create` | This allows Segment to determine if the tables Segment uses to track state in the `__segment_reverse_etl` dataset exists. | |
| `bigquery.jobs.create` | This allows Segment to execute queries on any datasets or tables your model query references, and also allows Segment to manage tables used for tracking. |
There was a problem hiding this comment.
Hey @stayseesong, I assume the above suggested change for line 47 applies to line 40 as well?
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md
Show resolved
Hide resolved
stayseesong
added
the
content-update
stayseesong
approved these changes
Aug 1, 2023
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updating the permissions required if a rETL BigQuery customer creates the
__segment_reverse_etldataset themselves.Merge timing
ASAP once approved
Related issues (optional)