Skip to content

Protocols data type definitions and impact on WH #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

muhammadatifjav
Copy link
Contributor

Proposed changes

Add FAQs to WH and Protocols docs to explain that protocol data type definitions don't have an impact on the warehouse schema

Merge timing

  • ASAP once approved

Related issues (optional)

https://segment.atlassian.net/browse/KCS-611
https://segment.zendesk.com/agent/tickets/521061

@muhammadatifjav muhammadatifjav marked this pull request as ready for review October 16, 2023 23:33
Copy link
Contributor Author

@muhammadatifjav muhammadatifjav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Isabella for the suggestions!

@forstisabella forstisabella merged commit 3e98317 into develop Oct 19, 2023
@forstisabella forstisabella deleted the protocols-wh-datatypes branch October 19, 2023 16:08
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants