Skip to content

feat(code): remove public api token requirement for segment profiles destination #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

JasonSooter
Copy link
Contributor

@JasonSooter JasonSooter commented Sep 11, 2023

Proposed changes

Before this PR:

  • The documentation for the Segment Profiles Destination included steps to create & use a Public API Token

After this PR:

  • This requirement is no longer required as STRATCONN-2388 removed the need for a Public API Token

Reason that prompted this change:
Slack Thread in #questions-reverse-etl

Merge timing

  • ASAP once approved?

**Before this PR:**
- The documentation for the Segment Profiles Destination included steps to create & use a Public API Token

**After this PR:**
- This requirement is no longer required as [STRATCONN-2388](https://segment.atlassian.net/browse/STRATCONN-2388) removed the need for a Public API Token

**Reason that prompted this change:**
[Slack Thread in #questions-reverse-etl](https://twilio.slack.com/archives/C03NK2Y2GTC/p1694470953510579)
@JasonSooter JasonSooter requested a review from a team as a code owner September 11, 2023 22:50
@JasonSooter JasonSooter requested review from pwseg and removed request for a team September 11, 2023 22:50
@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Sep 12, 2023
@pwseg pwseg merged commit 7639af8 into develop Sep 12, 2023
@pwseg pwseg deleted the feat/remove-need-for-public-api-token branch September 12, 2023 08:39
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants