Skip to content

Update kotlin-android-plugin-architecture.md #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

clarksandholtz
Copy link
Contributor

Update plugin examples to remove non-existent name field and fix order of lateinit property

Proposed changes

The simple plugin examples were overriding a field that doesn't exist on the Plugin interface. Also, the lateinit keyword has to come before the var keyword.

Merge timing

Not urgent, but also it is just a docs change, so might as well push it out as it doesn't change any underlying code.

Related issues (optional)

Update plugin examples to remove non-existent `name` field and fix order of `lateinit` property
@clarksandholtz clarksandholtz requested a review from a team as a code owner October 16, 2023 17:57
@clarksandholtz clarksandholtz requested review from stayseesong and removed request for a team October 16, 2023 17:57
@stayseesong stayseesong added the content-update updates to content that are not new features, includes grammar fixes, added notes label Oct 16, 2023
@stayseesong stayseesong merged commit 77278f9 into segmentio:develop Oct 16, 2023
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants