Skip to content

docs(RN): update code blocks to ease copy feature #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

kud
Copy link
Contributor

@kud kud commented Nov 1, 2023

Proposed changes

It is better to have two blocks to facilitate the copy button feature.

image

Merge timing

Related issues (optional)

@kud kud requested a review from a team as a code owner November 1, 2023 17:29
@kud kud requested review from stayseesong and removed request for a team November 1, 2023 17:29
@kud
Copy link
Contributor Author

kud commented Nov 1, 2023

Also, one question, is @segment/sovran-react-native still mandatory? It seems that this project is deprecated now.

@stayseesong
Copy link
Contributor

stayseesong commented Nov 1, 2023

@kud thanks for submitting this PR! @segment/sovran-react-native isn't mandatory, you can use your own storage solution if you want, but it’s strongly recommended to use it. It's also not deprecated, the repo just moved to here: https://github.com/segmentio/analytics-react-native/tree/master/packages/sovran. I've updated the docs file so that it directs to the correct link.

I've also added in "or" in between the code blocks, as it's not clear to users that they can install in 1 of 2 ways. what do you think?

@kud
Copy link
Contributor Author

kud commented Nov 1, 2023

Oh, I see. Thanks!

For some reason, I ended up on the archived GitHub repository. Alright, thanks for the explanation. Is it similar to Zustand?

Regarding the code blocks, "or" is a good point indeed! Thanks!

@stayseesong stayseesong added the content-update updates to content that are not new features, includes grammar fixes, added notes label Nov 2, 2023
@stayseesong stayseesong merged commit 6627fbd into segmentio:develop Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@kud kud deleted the patch-1 branch November 2, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants