Skip to content

Fix the provided snippet.md #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix the provided snippet.md #5641

merged 2 commits into from
Nov 3, 2023

Conversation

prigiattiperrut
Copy link
Contributor

Proposed changes

Fix the provided snippet as the modified code was being called before the destination had finished loading so it was returning any value. Also updated the snippet version to the latest version.

Merge timing

  • ASAP once approved?

Related issues (optional)

Zendesk ticket: https://segment.zendesk.com/agent/tickets/525888

@prigiattiperrut prigiattiperrut requested a review from a team as a code owner November 3, 2023 17:03
@prigiattiperrut prigiattiperrut requested review from forstisabella and removed request for a team November 3, 2023 17:03
@forstisabella forstisabella merged commit c3c2444 into develop Nov 3, 2023
@forstisabella forstisabella deleted the prigiattiperrut-patch-3 branch November 3, 2023 17:18
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants