Skip to content

Refactor sources catalog [DOC-744] #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 2, 2024
Merged

Refactor sources catalog [DOC-744] #5750

merged 12 commits into from
Jan 2, 2024

Conversation

forstisabella
Copy link
Contributor

@forstisabella forstisabella commented Nov 30, 2023

Proposed changes

A CSE reached out about updating the destinations/sources catalog to match what's in the in-app catalog. I made the following updates to the source catalog:

  • Added categories that would normally fall under the cloud-apps section
  • Added beta flag to sources that are in beta (and created beta_sources.yml to power that)
  • Updated menu and sidenav files to match what's displayed on /docs/connections/sources/catalog page

Merge timing

After approval from the docs team! (It's already been approved by the CSE that raised this issue)

Related issues (optional)

@forstisabella forstisabella added the back-end fixes or updates to the site itself, which should not go in release notes label Nov 30, 2023
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 789f30a
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6573b68e3f0b620008ffe1e4
😎 Deploy Preview https://deploy-preview-5750--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@forstisabella forstisabella added fixed-site A fix to the site itself that we want to communicate in a release and removed back-end fixes or updates to the site itself, which should not go in release notes labels Dec 8, 2023
@forstisabella forstisabella requested a review from joeynmq December 9, 2023 00:44
@forstisabella forstisabella removed the request for review from joeynmq January 2, 2024 17:37
@forstisabella forstisabella marked this pull request as ready for review January 2, 2024 17:37
@forstisabella forstisabella requested a review from a team as a code owner January 2, 2024 17:37
@forstisabella forstisabella requested review from rchinn1 and removed request for a team January 2, 2024 17:37
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@forstisabella forstisabella merged commit b64e383 into develop Jan 2, 2024
@forstisabella forstisabella deleted the catalog-refactor branch January 2, 2024 18:00
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-site A fix to the site itself that we want to communicate in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants