Skip to content

Add note on returning event object in handler #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

bobbyatsegment
Copy link
Contributor

Proposed changes

Docs don't currently call out that the event object needs to be returned at the end of a method handler in order for the connected destination to proceed with processing the Function-modified event payload.

Added a note under the section to code the insert function that mentions this.

Merge timing

Related issues (optional)

@bobbyatsegment bobbyatsegment marked this pull request as ready for review December 5, 2023 19:30
@bobbyatsegment bobbyatsegment requested a review from a team as a code owner December 5, 2023 19:30
@bobbyatsegment bobbyatsegment requested review from stayseesong and removed request for a team December 5, 2023 19:30
@stayseesong stayseesong merged commit 5898421 into develop Dec 11, 2023
@stayseesong stayseesong deleted the bobbyatsegment-patch-1 branch December 11, 2023 23:14
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants