Skip to content

Updating OneSignal Partner Source Documentation #5819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

fhboswell
Copy link
Contributor

@fhboswell fhboswell commented Dec 19, 2023

Proposed changes

  • Updating events and properties in the OneSignal source doc

Merge timing

  • ASAP once approved

@fhboswell fhboswell requested a review from a team as a code owner December 19, 2023 17:36
@fhboswell fhboswell requested review from rchinn1 and removed request for a team December 19, 2023 17:36
@tcgilbert
Copy link
Contributor

@rchinn-segment I'm currently seeing object cloud source for this source. I believe this is because the last time this page was built the integration was hidden.
Screenshot 2023-12-27 at 11 09 53 AM

Running make catalog corrects for this locally, but just want to ensure this is corrected when merged and deployed
Screenshot 2023-12-27 at 11 11 04 AM

@rchinn1
Copy link
Contributor

rchinn1 commented Dec 27, 2023

@tcgilbert - Thanks for calling this out. We'll run make catalog before deploying this along with the rest of the docs

@fhboswell fhboswell requested a review from tcgilbert January 3, 2024 17:29
@fhboswell fhboswell requested a review from rchinn1 January 3, 2024 17:30
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Once @tcgilbert approves, I'll include this in an upcoming deploy

Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rchinn1 rchinn1 added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jan 4, 2024
@rchinn1 rchinn1 merged commit 120dd64 into segmentio:develop Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants