Add npm steps to A.js setup [DOC-771] #5854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmastr
reviewed
Jan 9, 2024
Comment on lines
28
to
30
| [1. Install Segment as a NPM package](#step-2a-install-segment-as-a-npm-package) | ||
|
|
||
| [2. Add the Segment snippet to your app](#step-2b-add-the-segment-snippet) |
There was a problem hiding this comment.
Maybe these should be a and b to match the headings below?
cmastr
reviewed
Jan 9, 2024
src/connections/sources/catalog/libraries/website/javascript/quickstart.md
Outdated
Show resolved
Hide resolved
…uickstart.md Co-authored-by: Casie Oxford <[email protected]>
stayseesong
commented
Jan 9, 2024
src/connections/sources/catalog/libraries/website/javascript/quickstart.md
Outdated
Show resolved
Hide resolved
stayseesong
commented
Jan 9, 2024
src/connections/sources/catalog/libraries/website/javascript/quickstart.md
Outdated
Show resolved
Hide resolved
pwseg
approved these changes
Jan 9, 2024
silesky
reviewed
Jan 10, 2024
|
|
||
| [b. Add the Segment snippet to your app](#step-2b-add-the-segment-snippet) | ||
|
|
||
| ### Step 2a: Install Segment as a NPM package |
There was a problem hiding this comment.
This is kind of a nit but npm isn't actually supposed to be capitalized.
I generally do: npm (with the backticks) to highlight it.
silesky
reviewed
Jan 10, 2024
src/connections/sources/catalog/libraries/website/javascript/quickstart.md
Outdated
Show resolved
Hide resolved
|
Left a couple comments, but looks great! |
stayseesong
added
the
content-update
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge timing
Related issues (optional)