Skip to content

rETL - Add FAQ for Syntax errors #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024
Merged

rETL - Add FAQ for Syntax errors #6141

merged 3 commits into from
Mar 7, 2024

Conversation

joeynmq
Copy link
Contributor

@joeynmq joeynmq commented Feb 28, 2024

Proposed changes

Customer reported seeing errors when adding inline comments to the end of the query for rETL:
googleapi: Error 400: Syntax error: Expected ")" but got ";"

Engineers have confirmed in this Jira that this is expected:

Hi team, this is not a bug. In RETL, we execute customer’s queries in a common table expression, which can only bind the results from one single subquery (link to Google doc). If there are multiple ; in the customer query, they'll be treated as several subqueries (even if the 2nd part is only an inline comment), and thus caused this syntax error.

As pointed out in the ticket body, a simple solution is just to remove the ;.

Merge timing

ASAP once approved

Related issues (optional)

@joeynmq joeynmq added the KCS label Feb 28, 2024
@joeynmq joeynmq marked this pull request as ready for review March 7, 2024 08:23
@joeynmq joeynmq requested a review from a team as a code owner March 7, 2024 08:24
@joeynmq joeynmq requested review from forstisabella and removed request for a team March 7, 2024 08:24
@forstisabella forstisabella merged commit c9fcab7 into develop Mar 7, 2024
@forstisabella forstisabella deleted the joeynmq-patch-4 branch March 7, 2024 18:08
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants