Skip to content

Niall/partner partial #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Niall/partner partial #6326

merged 4 commits into from
Apr 5, 2024

Conversation

niallzato
Copy link
Contributor

Proposed changes

Show partner status for partner owned integrations

@niallzato niallzato requested a review from a team as a code owner April 1, 2024 14:06
@niallzato niallzato requested review from pwseg and removed request for a team April 1, 2024 14:06
@niallzato niallzato added the KCS label Apr 1, 2024
@niallzato niallzato requested a review from forstisabella April 2, 2024 15:40
@forstisabella
Copy link
Contributor

hi @niallzato - I think this looks great! I did have one question: I built this locally to spot-check it, and I found that the new note only appears in some destinations. Is that intentional?

@niallzato
Copy link
Contributor Author

niallzato commented Apr 3, 2024

hi @niallzato - I think this looks great! I did have one question: I built this locally to spot-check it, and I found that the new note only appears in some destinations. Is that intentional?

@forstisabella correct, my thinking was to only show if for destinations that are partner owned, as the info is only really relevant for those destinations.
I thought seeing something like the following on destinations we own (GA4 etc) would be a bit redundant:

Partner Status
Not partner owned.

@forstisabella
Copy link
Contributor

hi @niallzato - I think this looks great! I did have one question: I built this locally to spot-check it, and I found that the new note only appears in some destinations. Is that intentional?

@forstisabella correct, my thinking was to only show if for destinations that are partner owned, as the info is only really relevant for those destinations. I thought seeing something like the following on destinations we own (GA4 etc) would be a bit redundant:

Partner Status
Not partner owned.

makes total sense - approved!

@forstisabella forstisabella merged commit 6d88527 into develop Apr 5, 2024
@forstisabella forstisabella deleted the niall/partner_partial branch April 5, 2024 15:30
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants