Remove no settings text from actions-fields.html #6343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cmastr
approved these changes
Apr 4, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes the generated line of text "No settings available. The destination may not be publicly visible." when no settings are detected for a destination. Many destinations intentionally do not have top-level settings. This is resulting in an incorrect warning on a growing number of docs pages that could lead to confusion for customers. See a sample Google search here: https://www.google.com/search?q=site:segment.com/docs+%22No+settings+available.+The+destination+may+not+be+publicly+visible.%22&rlz=1C5GCCM_en&sca_esv=9009150f6e709f7a&cs=0&filter=0&biw=1258&bih=934&dpr=2#ip=1
I generated a Netlify preview of this change, and the update looks good to me. Thanks!
Merge timing
Related issues (optional)