Skip to content

Remove line about config #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Remove line about config #6373

merged 1 commit into from
Apr 22, 2024

Conversation

sarahrudy
Copy link
Contributor

Proposed changes

  • the line "This command MUST be called at each new page load." is somewhat confusing because it sounds like this is something the customer needs to implement, but the config command is integrated into Segment's integration code in the Set Configuration Fields mapping

Merge timing

  • ASAP once approved

- the line "This command MUST be called at each new page load." is somewhat confusing because it sounds like this is something the customer needs to implement, but the config command is integrated into Segment's integration code in the Set Configuration Fields mapping
@sarahrudy sarahrudy added the KCS label Apr 11, 2024
@sarahrudy sarahrudy marked this pull request as ready for review April 22, 2024 13:40
@sarahrudy sarahrudy requested a review from a team as a code owner April 22, 2024 13:40
@sarahrudy sarahrudy requested review from cmastr and removed request for a team April 22, 2024 13:40
@cmastr cmastr merged commit 5dda0f4 into develop Apr 22, 2024
@cmastr cmastr deleted the sarahrudy-patch-1 branch April 22, 2024 13:53
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants