Skip to content

Add documentation for Magellan AI (Actions) Destination #6439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 1, 2024

Conversation

leboshi
Copy link
Contributor

@leboshi leboshi commented Apr 24, 2024

Proposed changes

Merge timing

Pending approval of the actual action destination PR

Notes

Documentation contains a comment at the end about important notes for three action mappings:

  • The Magellan AI API spec requires a user agent for the Install and Third-party event mobile app actions, but the Segment iOS library does not provide this in the event context. Alternatives are suggested.
  • There isn't a clear 1:1 between the Segment Signed Up B2B SaaS event and our Lead action, which is more of an e-commerce action but doesn't directly correlate with any of the Segment spec e-commerce events, so mapping suggestions are provided.

Thank you, and let us know what next steps you need from us!

@leboshi leboshi requested a review from a team as a code owner April 24, 2024 20:15
@leboshi leboshi requested review from forstisabella and removed request for a team April 24, 2024 20:15
@forstisabella forstisabella requested a review from tcgilbert April 25, 2024 16:03
@forstisabella forstisabella added the new-integration Added a new source or destination label Apr 25, 2024
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the requested change you will need to change the folder name from actions-magellan-ai to magellan-ai as this is the slug of your integration

@leboshi
Copy link
Contributor Author

leboshi commented Apr 25, 2024

Great! Moved the slug, and committed the ID metadata. Thanks!

@forstisabella forstisabella requested a review from tcgilbert April 25, 2024 22:44
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes from me and we'll be ready to ship this! 🚀

@leboshi
Copy link
Contributor Author

leboshi commented Apr 26, 2024

Thank you for the thorough pass! Y'all are incredible. Also updated the actual job title, to appease The People Upstairs when I asked about the capitalization.

@forstisabella
Copy link
Contributor

sweet!! Thanks so much for giving this PR so much thought. We're good to go, but I'll hold this until the corresponding PR in the action-destination repo is complete!

leboshi added a commit to magellan-ai/segment-action-destinations that referenced this pull request May 1, 2024
@leboshi
Copy link
Contributor Author

leboshi commented May 1, 2024

Hey @forstisabella! The destination PR has been approved and deployed. However, I just noticed that both the reviewer and I missed that our slug is still actions-magellan-ai instead of magellan-ai in the metadata for the destination, per @tcgilbert's request above. Soooooo there may already be a fix PR going up, as well, but the destination does indeed exist now! 🙈

@leboshi
Copy link
Contributor Author

leboshi commented May 1, 2024

OK, the contribution guide says

Do not change the name or slug of your Integration after the Integration has been deployed.

So I guess we're actions-magellan-ai now! Reverted the previous directory rename to match the slug.

@forstisabella
Copy link
Contributor

hi @leboshi - sweet, thanks for the update! I'll merge this docs PR and check after tomorrow's deploy that the link resolves as it should. If it doesn't, I can open a PR for a redirect. thanks for all of your work on these docs!

@forstisabella forstisabella merged commit 3e2ff3d into segmentio:develop May 1, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented May 1, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants