-
Notifications
You must be signed in to change notification settings - Fork 367
Add documentation for Magellan AI (Actions) Destination #6439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in addition to the requested change you will need to change the folder name from actions-magellan-ai
to magellan-ai
as this is the slug of your integration
src/connections/destinations/catalog/actions-magellan-ai/index.md
Outdated
Show resolved
Hide resolved
Great! Moved the slug, and committed the ID metadata. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few changes from me and we'll be ready to ship this! 🚀
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Co-authored-by: forstisabella <[email protected]>
Thank you for the thorough pass! Y'all are incredible. Also updated the actual job title, to appease The People Upstairs when I asked about the capitalization. |
sweet!! Thanks so much for giving this PR so much thought. We're good to go, but I'll hold this until the corresponding PR in the action-destination repo is complete! |
Hey @forstisabella! The destination PR has been approved and deployed. However, I just noticed that both the reviewer and I missed that our slug is still |
Deployed as `actions-magellan-ai`
OK, the contribution guide says
So I guess we're |
hi @leboshi - sweet, thanks for the update! I'll merge this docs PR and check after tomorrow's deploy that the link resolves as it should. If it doesn't, I can open a PR for a redirect. thanks for all of your work on these docs! |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Merge timing
Pending approval of the actual action destination PR
Notes
Documentation contains a comment at the end about important notes for three action mappings:
Install
andThird-party event
mobile app actions, but the Segment iOS library does not provide this in the event context. Alternatives are suggested.Signed Up
B2B SaaS event and ourLead
action, which is more of an e-commerce action but doesn't directly correlate with any of the Segment spec e-commerce events, so mapping suggestions are provided.Thank you, and let us know what next steps you need from us!