Skip to content

OneTrust wrapper doc [DOC-895] #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2024
Merged

OneTrust wrapper doc [DOC-895] #6455

merged 8 commits into from
May 2, 2024

Conversation

forstisabella
Copy link
Contributor

@forstisabella forstisabella commented Apr 26, 2024

Proposed changes

Added a page to the Consent Management docs set about the configurations of the a.js OneTrust wrapper that aren't supported and might lead to data loss

Merge timing

Thursday, May 2

Related issues (optional)

#6106

@forstisabella forstisabella added the content-update updates to content that are not new features, includes grammar fixes, added notes label Apr 26, 2024
@forstisabella forstisabella requested a review from a team as a code owner April 26, 2024 23:09
@forstisabella forstisabella requested review from pwseg and silesky and removed request for a team April 26, 2024 23:09
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit cdb8a9f
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/6632917bb3a5ba0008288224
😎 Deploy Preview https://deploy-preview-6455--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@pwseg pwseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, other than that LGTM.


#### Low

Segment assess some behaviors to have a low possibility of data loss because Twilio Segment Analytics.js and third-party device mode libraries are loaded only after the user has provided their consent (for consent banners a user **must** interact with to use your site) or your site assumes that a user consents (if you set your cookie banner on your site to be optional and never displayed to a user).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be reading this wrong, but did you mean "Segment assessed" or "Segment assesses"?


#### Medium

Segment assess some banner behaviors, like those that always remain as a user navigates your site and those that disappear after a user action like clicking or scrolling, to be at a medium possibility for data loss and noncompliance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, re: "assess."

@forstisabella forstisabella merged commit cb95acc into develop May 2, 2024
4 checks passed
@forstisabella forstisabella deleted the DOC-895 branch May 2, 2024 17:06
Copy link
Contributor

github-actions bot commented May 2, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants