Skip to content

Change redismod docker to redis-stack-server (#2556) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

zach-iee
Copy link

@zach-iee zach-iee commented Aug 24, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

this fixes the issue of standalone tests failing due to redis not booting up

* Change redismod docker to redis-stack-server

* redis-stack-server

* syntax

* Update tox.ini

* fetching docker from redis repo

Co-authored-by: Chayim I. Kirshen <[email protected]>
@zach-iee zach-iee self-assigned this Aug 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (68ef50a) 60.19% compared to head (4f4f027) 60.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.4      #12      +/-   ##
==========================================
+ Coverage   60.19%   60.21%   +0.02%     
==========================================
  Files         116      116              
  Lines       30282    30282              
==========================================
+ Hits        18228    18235       +7     
+ Misses      12054    12047       -7     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zach-iee zach-iee merged commit 1856a34 into 4.4 Aug 24, 2023
@zach-iee zach-iee deleted the 4.4_redis_stack branch August 24, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants