Skip to content

[GROW-3262] add __repr__ to RedisCluster objects #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

zach-iee
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

when looking through sentry, it's hard to debug redis-py related issues, because object is not represented well. This PR added __repr__ method to NodeCommands and PipelineCommand to show data on sentry

current:
image

with this PR:
image

@zach-iee zach-iee self-assigned this Aug 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05% ⚠️

Comparison is base (d5533db) 92.35% compared to head (ae41464) 92.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   92.35%   92.31%   -0.05%     
==========================================
  Files         119      119              
  Lines       30678    30682       +4     
==========================================
- Hits        28334    28325       -9     
- Misses       2344     2357      +13     
Files Changed Coverage Δ
redis/cluster.py 90.71% <50.00%> (-0.19%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants