Skip to content

[GROW-2938] additional test to #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2023
Merged

[GROW-2938] additional test to #1 #2

merged 2 commits into from
Jun 28, 2023

Conversation

zach-iee
Copy link

@zach-iee zach-iee commented Jun 27, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

adding more tests to verify our custom patches made in #1

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (8a7897c) 92.10% compared to head (a382fda) 92.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   92.10%   92.29%   +0.18%     
==========================================
  Files         119      119              
  Lines       30547    30581      +34     
==========================================
+ Hits        28136    28225      +89     
+ Misses       2411     2356      -55     
Impacted Files Coverage Δ
tests/test_cluster.py 96.90% <100.00%> (+0.25%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zach-iee zach-iee force-pushed the GROW-2938 branch 2 times, most recently from f85fe76 to 3545546 Compare June 27, 2023 10:55
@zach-iee zach-iee requested review from bellatoris and noah-chae June 28, 2023 02:07
@zach-iee zach-iee marked this pull request as ready for review June 28, 2023 02:07
@zach-iee zach-iee merged commit 308c82b into master Jun 28, 2023
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Jun 28, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
@zach-iee zach-iee deleted the GROW-2938 branch July 3, 2023 06:14
zach-iee added a commit that referenced this pull request Jul 7, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
zach-iee added a commit that referenced this pull request Aug 21, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
zach-iee added a commit that referenced this pull request Aug 21, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
zach-iee added a commit that referenced this pull request Sep 14, 2023
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants