Skip to content

Cherry pick sharded pubsub commit into 4.5 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

noah-chae
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@noah-chae noah-chae requested a review from zach-iee July 28, 2023 06:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 27.13% and project coverage change: -0.79% ⚠️

Comparison is base (1064caa) 92.33% compared to head (3565a39) 91.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.5       #9      +/-   ##
==========================================
- Coverage   92.33%   91.55%   -0.79%     
==========================================
  Files         116      116              
  Lines       30346    30666     +320     
==========================================
+ Hits        28020    28076      +56     
- Misses       2326     2590     +264     
Files Changed Coverage Δ
tests/test_asyncio/test_pubsub.py 99.37% <ø> (ø)
redis/cluster.py 85.40% <15.71%> (-5.50%) ⬇️
tests/test_pubsub.py 76.20% <27.52%> (-23.41%) ⬇️
redis/client.py 87.19% <37.20%> (-2.42%) ⬇️
redis/commands/core.py 81.97% <50.00%> (-0.11%) ⬇️
redis/commands/parser.py 63.33% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zach-iee zach-iee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noah-chae this one doesn't need to get merged to master, because it already has changes from 5.0?

@zach-iee zach-iee force-pushed the 4.5-cherry-pick-sharded-pubsub branch from 0e75eb9 to 3565a39 Compare August 24, 2023 04:43
@zach-iee
Copy link

@noah-chae i've rebased to 4.5 and fixed import order

@noah-chae
Copy link
Author

@noah-chae this one doesn't need to get merged to master, because it already has changes from 5.0?

Yes that's right. I missed this comment sorry for late reply

@noah-chae
Copy link
Author

@noah-chae i've rebased to 4.5 and fixed import order

Super thanks 🙏

@noah-chae noah-chae merged commit e05ef48 into 4.5 Aug 31, 2023
@noah-chae noah-chae deleted the 4.5-cherry-pick-sharded-pubsub branch August 31, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants