DeepDiff 6 #337
Merged
DeepDiff 6 #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
seperman
commented
Aug 13, 2022
seperman
commented
- This is not a major upgrade of DeepDiff. The main reason to go to 6 is how we will be publishing it on pypi. It will be published under DeepDiff6.
Added python and deepdiff versions to bug template
This commit addresses two issues. First ensuring that the diff indexes for moved items are always relative to t2 (except for removed) to stay consistent with the rest of the diff types. Second, when replaying moved items ensure that the new values is replaced after adding the items. Since the moved items already have any nested items inside of them, there is no need to replay those nested added items (it was causing items to get double added).
Fix for diffing using iterable_compare_func with nested objects.
Update bug_report.md
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 99.53% 99.50% -0.03%
==========================================
Files 14 14
Lines 2988 3016 +28
==========================================
+ Hits 2974 3001 +27
- Misses 14 15 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.