Skip to content

Fix for #205 allow collector path in host url #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

EEParker
Copy link
Collaborator

@EEParker EEParker commented Jun 5, 2024

This should allow for the previous collector path in the host url.

@EEParker EEParker requested a review from VictorioBerra June 5, 2024 19:23
@EEParker EEParker self-assigned this Jun 5, 2024
@EEParker EEParker added enhancement component-HEC Semver-Patch Patch Update - non-breaking changes labels Jun 5, 2024
@EEParker
Copy link
Collaborator Author

EEParker commented Jun 5, 2024

@VictorioBerra can you test this to see if it meets your needs?

Copy link

github-actions bot commented Jun 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
Serilog.Sinks.Splunk 50% 63%
Serilog.Sinks.Splunk.TCP 65% 43%
Serilog.Sinks.Splunk 19% 19%
Summary 43% (334 / 812) 44% (86 / 208)

@EEParker EEParker added this to the 5.0 milestone Jun 5, 2024
@EEParker EEParker added bug and removed enhancement labels Jun 5, 2024
@EEParker EEParker merged commit cdf7167 into dev Jun 5, 2024
4 checks passed
@VictorioBerra
Copy link
Member

@EEParker Works great!

My config

  "Serilog": {
    "WriteTo": [
      {
        "Name": "EventCollector",
        "Args": {
          "splunkHost": "https://splunk.company.com/services/collector",
          "eventCollectorToken": "111-222-333-444-555"
        }
      }
    ]
  }

@EEParker EEParker deleted the bugfix/205-collector-path branch June 12, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component-HEC Semver-Patch Patch Update - non-breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants