Fix (#96) improve datetime parsing on sql server #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mo-esmp, I tried a fix for #96 + added Teronis package to package the nuget with the referenced dll (I didn't find a way to dotnet pack and include the reference to serilog.ui.core...) If you like both changes, I'd move onwards and publish an alpha version for mssql provider, to let users test it (and test nuget publication from my side) 😄 |
|
Sorry for the late response. Do we need to add some tests regarding the bug? because for me it is still unclear under what circumstances this bug can happen. |
|
tests added, let me know if the bug and its fix are more clear 😄 |
mo-esmp
approved these changes
Jan 13, 2024
|
Thanks for adding tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #96, by changing the default datetime parsing in MS SQL Provider.
The default parse will assume that the date saved in the database is related to the application culture, assuming it's local based.
If the user isn't satisfied by the default parsing, a new parameter can be used to customize the datetime parsing. The DateTime produced must be UTC-kind or the app will throw an exception.
EDIT: it also bumps npm libraries (will close the other PRs later)