Add RavenDB provider. #111 #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I applied your suggestion and got the same result.
I got stuck and have no idea how I can fix these two tests :-/ |
|
Ciao @mo-esmp you missed the changes from tests/Serilog.Ui.RavenDbProvider.Tests/DataProvider/DataProviderSearchTest.cs in that commit, try to apply it and at least the all-filters should work :) after that update, I'll refetch your branch and check if the tests still not pass! |
|
Sorry, I didn't get you. What changes did I miss? |
|
I meant this file but, if it's okay for you, you can skip the failing tests - in the 3.0 development wip I'm unifying and updating all tests, thus I can re-enable these ones on that branch :) |
|
Ciao @followynne |
followynne
approved these changes
Mar 14, 2024
src/Serilog.Ui.RavenDbProvider/Extensions/SerilogUiOptionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Serilog.Ui.RavenDbProvider/Serilog.Ui.RavenDbProvider.nuspec
Outdated
Show resolved
Hide resolved
followynne
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @followynne
I need your help. Three tests fail, and it's related to UTC datetime and I could figure out what's the problem. Could you please check when you have time?