Skip to content

fix #167: create new option to provide server deployment sub-path #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

followynne
Copy link
Member

@mo-esmp

(I'm double-testing the fix those day, you can already check/approve the PR with failing test as I will re-align the branch after merging #166, to have working pipelines and relaunch the tests)

@followynne followynne requested a review from mo-esmp March 22, 2025 11:36
Copy link
Member

@mo-esmp mo-esmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

@followynne followynne requested a review from mo-esmp March 29, 2025 14:39
@followynne followynne enabled auto-merge (squash) March 29, 2025 14:39
auto-merge was automatically disabled March 29, 2025 17:38

Head branch was pushed to by a user without write access

@matteo-gregoricchio-deltatre matteo-gregoricchio-deltatre force-pushed the fix/167-add-server-sub-path-option branch from de4db2f to 0274413 Compare March 29, 2025 17:38
@followynne followynne enabled auto-merge (squash) March 29, 2025 17:39
@followynne
Copy link
Member Author

@mo-esmp

FYI, I also added the maintenance work on the build/pipelines to this PR 👍
Next steps will be:

  • after merging the PR, I'll make the patch version for the 2 open bugs (Web 3.1.1)
  • I'll create the PR with the live-feed button
  • I'll create a final PR where
    • remove net7 from supported frameworks (as they're doing in other packages)
    • upgrade Mongo SDK to v3 (as it contains breaking changes)
    • upgrade all packages of a minor version
      and finally release the new minors 👍

@followynne followynne merged commit b9d33d1 into serilog-contrib:master Mar 31, 2025
2 checks passed
@followynne followynne deleted the fix/167-add-server-sub-path-option branch April 1, 2025 06:51
@followynne followynne linked an issue Apr 4, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local deployment IIS with alias
2 participants