Expose SerilogLoggerFactory
#19
Conversation
I needed to retrieve some configuration prior to registering the logger. `UseSerilog` is invoked before the `Startup` class. I sought to register the Factory manually but found out that is internal. I think that `SerilogLoggerFactory` is the main take away from this library and therefore exposing it would make it more flexible for those who don't want to use the extension methods.
|
Thanks for the PR, @jonathansant. Does the alternative overload of Best regards, |
|
Since all my startup logic is in the |
|
Thanks for the reply. I think providing the factory type is fine 👍 |
| /// Implements Microsoft's ILoggerFactory so that we can inject Serilog Logger. | ||
| /// </summary> | ||
| /// <seealso cref="Microsoft.Extensions.Logging.ILoggerFactory" /> | ||
| public class SerilogLoggerFactory : ILoggerFactory |
There was a problem hiding this comment.
Indentation is funny here and below - may need to use spaces, rather than tabs?
| @@ -18,26 +18,49 @@ | |||
|
|
|||
| namespace Serilog.AspNetCore | |||
| { | |||
| class SerilogLoggerFactory : ILoggerFactory | |||
| /// <summary> | |||
| /// Implements Microsoft's ILoggerFactory so that we can inject Serilog Logger. | |||
There was a problem hiding this comment.
Instead of Microsoft's ILoggerFactory we could use <see cref="ILoggerFactory"/>
| /// Initializes a new instance of the <see cref="SerilogLoggerFactory"/> class. | ||
| /// </summary> | ||
| /// <param name="logger">The logger.</param> | ||
| /// <param name="dispose">if set to <c>true</c> [dispose].</param> |
There was a problem hiding this comment.
Could use the same documentation here as in https://github.com/serilog/serilog-aspnetcore/blob/dev/src/Serilog.AspNetCore/SerilogWebHostBuilderExtensions.cs#L33
|
Thank you 👍 |
I needed to retrieve some configuration prior to registering the logger.
UseSerilogis invoked before theStartupclass. I sought to register the Factory manually but found out that is internal. I think thatSerilogLoggerFactoryis the main take away from this library and therefore exposing it would make it more flexible for those who don't want to use the extension methods.