Fix wildcard semantics; fix like clause anchoring #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Mar 7, 2021
| // If we hit a wildcard-compatible operation, then any wildcards within its operands "belong" to | ||
| // it and can't be the result of this search. | ||
| if (Operators.WildcardComparators.Contains(lx.OperatorName)) | ||
| return null; |
There was a problem hiding this comment.
This is the fix for wildcard translation - stop searching upon reaching another comparison.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serilog.Expressions has a number of language features in common with Seq (though the implementations are generally very different). I checked over how wildcards are evaluated after having a bug reported in Seq's implementation, to see whether similar issues existed over here.
And, yes! - Found some problems in how wildcards work, leading to potentially incorrect results in the presence of indexing into potentially-undefined values.
After adding some new test cases for that issue, I fleshed out testing of
likeand found that expressions aren't being correctly anchored, here -A like 'a%'should anchoraat the beginning of the target string, but doesn't, and end anchoring was similarly broken.This PR fixes both sets of issues.