Pass registered logger to DiagnosticContext #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DiagnosticContext should use the logger, which is passed to or created by UseSerilog().
|
Thanks for the PR! This looks good to me, but I'm short of time to dig properly into it right now and make sure we've considered all possible regressions. I'll try to loop back around to this soon, unless someone beats me to it :-) Apologies again for the slow turnaround. |
tabman83
approved these changes
Jul 1, 2022
|
We are faced with the same issue and we would appreciate if this could be considered for review & merge! Thanks! |
|
This should reach NuGet as a Any feedback on how it goes would be welcome, thanks 👍 Thanks for the PR, @cbersch! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DiagnosticContext should use the logger, which is passed to or created by UseSerilog().